eolivelli commented on a change in pull request #855: DbLedgerStorage -- Main implementation URL: https://github.com/apache/bookkeeper/pull/855#discussion_r157061070
########## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageWriteCacheTest.java ########## @@ -0,0 +1,133 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ +package org.apache.bookkeeper.bookie.storage.ldb; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.fail; + +import io.netty.buffer.ByteBuf; +import io.netty.buffer.Unpooled; + +import java.io.File; +import java.io.IOException; + +import org.apache.bookkeeper.bookie.Bookie; +import org.apache.bookkeeper.conf.ServerConfiguration; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +/** + * Unit test for {@link DbLedgerStorage}. + */ +public class DbLedgerStorageWriteCacheTest { + + private DbLedgerStorage storage; + private File tmpDir; + + private static class MockedDbLedgerStorage extends DbLedgerStorage { + + @Override + public synchronized void flush() throws IOException { + // Swap the write caches and block indefinitely to simulate a slow disk + WriteCache tmp = writeCacheBeingFlushed; + writeCacheBeingFlushed = writeCache; + writeCache = tmp; + + // since the cache is switched, we can allow flush to be triggered + hasFlushBeenTriggered.set(false); + + // Block the flushing thread + while (true) { + try { + Thread.sleep(1000); + } catch (InterruptedException e) { + return; + } + } + } + + } + + @Before + public void setup() throws Exception { + tmpDir = File.createTempFile("bkTest", ".dir"); + tmpDir.delete(); + tmpDir.mkdir(); + File curDir = Bookie.getCurrentDirectory(tmpDir); + Bookie.checkDirectoryStructure(curDir); + + int gcWaitTime = 1000; + ServerConfiguration conf = new ServerConfiguration(); + conf.setGcWaitTime(gcWaitTime); + conf.setAllowLoopback(true); + conf.setLedgerStorageClass(MockedDbLedgerStorage.class.getName()); + conf.setProperty(DbLedgerStorage.WRITE_CACHE_MAX_SIZE_MB, 1); + conf.setLedgerDirNames(new String[] { tmpDir.toString() }); + Bookie bookie = new Bookie(conf); + + storage = (DbLedgerStorage) bookie.getLedgerStorage(); Review comment: This is never closed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
