dlg99 commented on a change in pull request #856: ISSUE #590 (@bug W-4556980@) Reduce excessive CPU usage on client side: add crc3? URL: https://github.com/apache/bookkeeper/pull/856#discussion_r157134519
########## File path: microbenchmarks/pom.xml ########## @@ -0,0 +1,151 @@ +<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor + license agreements. See the NOTICE file distributed with this work for additional + information regarding copyright ownership. The ASF licenses this file to + You under the Apache License, Version 2.0 (the "License"); you may not use + this file except in compliance with the License. You may obtain a copy of + the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required + by applicable law or agreed to in writing, software distributed under the + License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS + OF ANY KIND, either express or implied. See the License for the specific + language governing permissions and limitations under the License. --> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.bookkeeper</groupId> + <artifactId>bookkeeper</artifactId> + <version>4.7.0-SNAPSHOT</version> + </parent> + <artifactId>microbenchmarks</artifactId> Review comment: @sijie I added this one for a few reasons: - I already had it like that ;) - jmh-bench did not build even after I fixed version in pom. "ProtocolBenchmark.java:[88,41] constructor AddRequest in class org.apache.bookkeeper.proto.BookieProtocol.AddRequest cannot be applied to given types". - I was not sure what the plans fro jmh-bench are, given its current state. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
