pasha-kuznetsov opened a new issue #861: slf4j logging: use {} formatting 
instead of string concatenation
URL: https://github.com/apache/bookkeeper/issues/861
 
 
   Currently logging is done via both `{}` slf4j formatting, and `+` string 
concatenation. The former `{}` is preferrable for consistency, readability and 
[performance](https://www.slf4j.org/faq.html#logging_performance).
   
   **Example**
   The following
   ```
   LOG.debug("Unsetting success for ledger: " + lh.ledgerId + " entry: " + 
entryId
              + " bookie index: " + bookieIndex);
   ```
   would be changed to
   ```
   LOG.debug("Unsetting success for ledger: {} entry: {} bookie index: {}",
             lh.ledgerId, entryId, bookieIndex);
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to