sijie commented on a change in pull request #856: ISSUE #590 (@bug W-4556980@)
Reduce excessive CPU usage on client side: add crc3?
URL: https://github.com/apache/bookkeeper/pull/856#discussion_r157268818
##########
File path: bookkeeper-server/pom.xml
##########
@@ -182,6 +182,11 @@
<artifactId>http-server</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review comment:
@dlg99 the approach you took didn't work because the assemble code of using
intel crc32c instruction is a hotspot code which only available in jdk9. you
can port the code from java9 to java8 and it can compile and work, but jdk8
doesn't this assemble code, so why you won't see any performance difference.
You can checkout the hotspot code here
http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a60e232aa8f2#l11.20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
