pasha-kuznetsov commented on issue #861: slf4j logging: use {} formatting 
instead of string concatenation
URL: https://github.com/apache/bookkeeper/issues/861#issuecomment-352123821
 
 
   Related change is that then many `if (LOG.isDebugEnabled())` checks can be 
removed as they are done automatically by slf4j without extra overhead in case 
of `{}` formatting, e.g.:
   ```
               if (LOG.isDebugEnabled()) {
                   LOG.debug("Failed to close ledger {} : ", ledgerId, re);
               }
   ```
   is then simplified to
   ```
               LOG.debug("Failed to close ledger {} : ", ledgerId, re);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to