dlg99 commented on a change in pull request #868: ISSUE #863: BK client error
messages needs to be more descriptive
URL: https://github.com/apache/bookkeeper/pull/868#discussion_r157330852
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java
##########
@@ -122,7 +123,7 @@ ByteBuf getExplicitLac() {
}
ByteBuf entry = createLedgerFenceEntry(ledgerId);
journal.logAddEntry(entry, (rc, ledgerId, entryId, addr, ctx) -> {
- LOG.debug("Record fenced state for ledger {} in journal with rc
{}", ledgerId, rc);
+ LOG.debug("Record fenced state for ledger {} in journal with rc
{}", ledgerId, BKException.codeLogger(rc));
Review comment:
wrap this with
if (LOG.isDebugEnabled()) {
LOG.debug ...
}
codeLogger() creates new objects and in 99.9% of cases debug logging is off.
This lets us bypass extra object creation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
