ArvinDevel commented on a change in pull request #873: Issue280: Turn bookie
into readonly when sortedLedgerStorage failed to flush data
URL: https://github.com/apache/bookkeeper/pull/873#discussion_r157643981
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
##########
@@ -862,6 +863,11 @@ public synchronized void start() {
ledgerStorage.start();
+ // if ledgerStorage is SortedLedgerStorage, then add
SortedLedgerStorageListener
+ if (ledgerStorage instanceof SortedLedgerStorage){
+ ((SortedLedgerStorage)
ledgerStorage).addSortedLedgerStorageListener(getSortedLedgerStorageListener());
Review comment:
Because flush failure is only relative to SortedLedgerStorage, so I just
changed the SortedLedgerStorage to avoid much changes. Do you think that adding
a common listener interface to LedgerStorage is ok? @sijie @eolivelli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
