eolivelli commented on a change in pull request #873: Issue280: Turn bookie
into readonly when sortedLedgerStorage failed to flush data
URL: https://github.com/apache/bookkeeper/pull/873#discussion_r157739085
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java
##########
@@ -781,7 +786,7 @@ public void testPersistBookieStatus() throws Exception {
bookie = bookieServer.getBookie();
assertTrue(bookie.isReadOnly());
// transition to writable mode
- bookie.doTransitionToWritableMode();
+ ((Bookie.BookieStateManager)
bookie.getStateManager()).doTransitionToWritableMode();
Review comment:
What about making "transitionToWritableMode" return a Future<Void> and than
call
bookie.getStateManager()).transitionToWritableMode().get()
so you won't need to access BookieStateManager ?
//cc @sijie @ivankelly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
