eolivelli commented on a change in pull request #873: Issue280: Turn bookie
into readonly when sortedLedgerStorage failed to flush data
URL: https://github.com/apache/bookkeeper/pull/873#discussion_r157767316
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java
##########
@@ -781,7 +786,7 @@ public void testPersistBookieStatus() throws Exception {
bookie = bookieServer.getBookie();
assertTrue(bookie.isReadOnly());
// transition to writable mode
- bookie.doTransitionToWritableMode();
+ ((Bookie.BookieStateManager)
bookie.getStateManager()).doTransitionToWritableMode();
Review comment:
@ArvinDevel my suggestion will preserve the same behavior without the need
of these casts.
Anyway we are in tests some some shortcut is allowed.
I am fine with keeping the casts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services