ivankelly commented on issue #888: Rework of binary distribution licenses URL: https://github.com/apache/bookkeeper/pull/888#issuecomment-352863510 > I don't think it is a good idea to pull in all the license and notice from all the dependencies. This isn't the licenses and notices from all the dependencies, only from the dependencies whose license requires it. > It will make maintenance and dependency upgrade complicated, It shouldn't. The check-binary-license script should flag if the license needs to be updated in CI. Updating the license is quick, I checked every dependency we have in one morning. > the license files will quickly get out of sync Again, the check-binary-license script should prevent this. > I think we should look for better solutions than this. I don't think there is a better solution than doing it manually. A script can't parse a NOTICE file to see what to bubble up. > also it would be good to create an issue for this and track the discussion there. Will create an issue.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
