sijie commented on a change in pull request #888: Rework of binary distribution
licenses
URL: https://github.com/apache/bookkeeper/pull/888#discussion_r157891307
##########
File path: bookkeeper-dist/src/assemble/bin-all.xml
##########
@@ -50,6 +50,11 @@
<include>${basedir}/*.txt</include>
</includes>
</fileSet>
+ <fileSet>
+ <directory>../src/main/resources/deps</directory>
Review comment:
we should not maintain the 3rdparty license. we should only attach the
needed notice and license that is required into NOTICE or LICENSE file.
maintaining this directory makes things complicated. we should avoid it.
The check script should parse pom files or the assemble tarballs to see what
dependencies are included, and fetch their corresponding notices and verify if
the NOTICE file includes all dependencies or not and if their licenses are
matched and notices are attached.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
