sijie commented on a change in pull request #873: Issue280: Turn bookie into
readonly when sortedLedgerStorage failed to flush data
URL: https://github.com/apache/bookkeeper/pull/873#discussion_r157924039
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
##########
@@ -245,12 +243,12 @@ public boolean accept(File dir, String name) {
}
@VisibleForTesting
- public void setRegistrationManager(RegistrationManager rm) {
- this.registrationManager = rm;
+ public synchronized void setRegistrationManager(RegistrationManager rm) {
Review comment:
I don't think you need `synchronized` if you make `stateManager` final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
