eolivelli commented on a change in pull request #889: BP-14 Implementation of
WriteFlag.DEFERRED_SYNC on Journal
URL: https://github.com/apache/bookkeeper/pull/889#discussion_r157955484
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
##########
@@ -283,30 +283,43 @@ public boolean accept(long journalId) {
WriteCallback cb;
Object ctx;
long enqueueTime;
+ boolean ackBeforeForce;
Review comment:
I think this is needed, because the lifecycle of the QueueEntry is
different, we can't simply fire the callback and forget about the entry, see my
comments below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
