ivankelly commented on a change in pull request #898: Bookies should prioritize
recovery reads/writes
URL: https://github.com/apache/bookkeeper/pull/898#discussion_r158288136
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
##########
@@ -152,6 +159,14 @@ public BookieRequestProcessor(ServerConfiguration
serverCfg, Bookie bookie,
createExecutor(
this.serverCfg.getNumLongPollWorkerThreads(),
"BookieLongPollThread-" + serverCfg.getBookiePort(),
OrderedScheduler.NO_TASK_LIMIT);
+ this.fenceThreadPool = Executors.newCachedThreadPool(
Review comment:
#283 is to submit a runnable to the read processor thread for checking the
fencing? I don't think this applies here. This fenceThreadPool is for V3. The
problem was that writeThreadPool and readThreadPool can reject executions, if
they hit a limit. This was causing failures in on of the tests for fencing
(testRecoveryNotRejected). I would think that fencing should be outside of
these execution limits, as it is part of recovery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
