sijie closed pull request #900: Fix: fail create-ledger callback on ledgerId
generation failure
URL: https://github.com/apache/bookkeeper/pull/900
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LongZkLedgerIdGenerator.java
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LongZkLedgerIdGenerator.java
index 5f7c4d8a3..c2cb07131 100644
---
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LongZkLedgerIdGenerator.java
+++
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LongZkLedgerIdGenerator.java
@@ -110,6 +110,10 @@ public void operationComplete(int rc, Long result) {
cb.operationComplete(BKException.Code.IllegalOpException, null);
}
+ } else {
+ LOG.error("Failed to create long ledger ID path",
+
KeeperException.create(KeeperException.Code.get(rc)));
+ cb.operationComplete(BKException.Code.ZKException, null);
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
