sijie commented on a change in pull request #905: ISSUE #904: short hostname 
for bookieid
URL: https://github.com/apache/bookkeeper/pull/905#discussion_r158410264
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
 ##########
 @@ -1244,8 +1244,6 @@ Options getOptions() {
             super(CMD_LISTBOOKIES);
             opts.addOption("rw", "readwrite", false, "Print readwrite 
bookies");
             opts.addOption("ro", "readonly", false, "Print readonly bookies");
-            opts.addOption("h", "hostnames", false,
 
 Review comment:
   oh there is not particular format. I was suggesting adding this to the 
description
   
   "Also print hostname of the bookie" =>
   
   "Also print hostname of the bookie (deprecated, 'rw'/'ro' option print both 
hostname and ip)"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to