ivankelly commented on issue #903: Integration/compatibility tests based on docker URL: https://github.com/apache/bookkeeper/issues/903#issuecomment-353662430 I don't think we should go with a classloader based approach. Classloader based would allow current jars versions, but that's all. These tests will be used to test failure cases like network partitions, which we can't test with junit. Each node needs to appear as its own machine for this, which is why I'm suggesting docker. The underlying assumption is that it will be with arquillian too, but I'd like to see how that works too. I would suspect that these tests will be too heavy to run on developer machines in any case, and I wouldn't expect a dev to run them before submitting a patch. Rather, they would be run as part of the pre commit. On Fri 22 Dec 2017, 19:11 Sijie Guo <[email protected]> wrote: > We can use isolated classloaders (and I think Arquillian uses this > approach) > > Not sure if Arquillian uses the approach you are suggesting. But If it > does, we should just go with Arquillian, no? Reinventing a testing > framework is not fun. > > ? > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/bookkeeper/issues/903#issuecomment-353649373>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AADWqwCw_oDAdk8sqTr83AF62rMinQK7ks5tC_DogaJpZM4RKMfZ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
