sijie commented on issue #916: Issue 915: Part 1 - Copy pulsar-checksum module as circe-checksum URL: https://github.com/apache/bookkeeper/pull/916#issuecomment-353735910 1) maintain and setup an external module required a lot of infrastructure wise work., E.g setting up to CI and publishing jars. I don't think we can do that. 2) maintain and setup an external module is effectively same as just using pulsar-checksum. The original author doesn't have a published maven artifacts, that was the reason that pulsar imports the code. We can't import pulsar-checksum directly, because of the recursive dependency will make things a bit hard to maintain if pulsar uses the official bk. Regarding modularize, I assume we only consider modularize when we bump the minimal Java support to Java 9. If we bump the minimal Java support to 9, then we should consider just using jdk crc32c. So I don't think this is a problem for modularize in future. But since this module is imported from pulsar, I would defer this to Matteo and see what is best solution for both bookkeeper and pulsar.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
