sijie commented on a change in pull request #851: Issue 578 : make
MajorCompaction controlled by time of the day/day of the week
URL: https://github.com/apache/bookkeeper/pull/851#discussion_r158772522
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -42,6 +42,10 @@
protected static final String MINOR_COMPACTION_THRESHOLD =
"minorCompactionThreshold";
protected static final String MAJOR_COMPACTION_INTERVAL =
"majorCompactionInterval";
protected static final String MAJOR_COMPACTION_THRESHOLD =
"majorCompactionThreshold";
+ protected static final String MAJOR_MEDIAN_COMPACTION_THRESHOLD =
"majorMedianCompactionThreshold";
Review comment:
add these new settings to
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/conf/bk_server.conf
and
https://github.com/apache/bookkeeper/blob/master/site/_data/config/bk_server.yaml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services