eolivelli commented on issue #922: Bookie and BookKeeperAdmin and BookKeeper 
client does not use shaded Protobuf JAR
URL: https://github.com/apache/bookkeeper/issues/922#issuecomment-354261389
 
 
   @sijie the bookkeeper-server with 'shaded' classifier has the protobuf 
dependency
   
   just try:
   ```
   <dependency>
               <groupId>org.apache.bookkeeper</groupId>
               <artifactId>bookkeeper-server</artifactId>
               <version>4.5.1</version>
   </dependency>
   ```
   and run 
   `mvn dependency:tree`
   
   you won't see protobuf
   
   ```
   +- org.apache.bookkeeper:bookkeeper-server:jar:4.5.1:compile
   |  +- org.slf4j:slf4j-log4j12:jar:1.7.25:compile
   |  +- org.apache.commons:commons-lang3:jar:3.3.2:compile
   |  +- net.java.dev.jna:jna:jar:3.2.7:compile
   |  +- io.netty:netty-all:jar:4.1.12.Final:compile
   |  \- io.netty:netty-tcnative-boringssl-static:jar:2.0.3.Final:compile
   ```
   
   if you switch to 4.6.0 version
   ```
   <dependency>
               <groupId>org.apache.bookkeeper</groupId>
               <artifactId>bookkeeper-server</artifactId>
               <version>4.5.1</version>
               <classifier>shaded<classifier>
   </dependency>
   ```
   
   you will see the protobuf 3.4.0 dep
   ```
   +- org.apache.bookkeeper:bookkeeper-server:jar:shaded:4.6.0:compile
   |  +- org.apache.bookkeeper:bookkeeper-common:jar:4.6.0:compile
   |  +- com.google.protobuf:protobuf-java:jar:3.4.0:compile
   |  +- org.slf4j:slf4j-log4j12:jar:1.7.25:compile
   |  +- org.apache.commons:commons-lang3:jar:3.3.2:compile
   |  +- org.apache.commons:commons-collections4:jar:4.1:compile
   |  +- net.java.dev.jna:jna:jar:3.2.7:compile
   |  +- io.netty:netty-all:jar:4.1.12.Final:compile
   |  +- io.netty:netty-tcnative-boringssl-static:jar:2.0.3.Final:compile
   |  \- org.apache.bookkeeper.http:http-server:jar:4.6.0:compile
   |     +- com.fasterxml.jackson.core:jackson-core:jar:2.8.9:compile
   |     +- com.fasterxml.jackson.core:jackson-databind:jar:2.8.9:compile
   |     \- com.fasterxml.jackson.core:jackson-annotations:jar:2.8.9:compile
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to