sijie commented on a change in pull request #832: Issue 620: Close the
fileChannels for read when they are idle
URL: https://github.com/apache/bookkeeper/pull/832#discussion_r158922671
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -47,7 +47,7 @@
protected static final String COMPACTION_RATE = "compactionRate";
protected static final String COMPACTION_RATE_BY_ENTRIES =
"compactionRateByEntries";
protected static final String COMPACTION_RATE_BY_BYTES =
"compactionRateByBytes";
- protected static final String EXPIRE_READ_CHANNEL_CACHE =
"expireReadChannelCache";
+ protected static final String READ_CHANNEL_CACHE_EXPIRE_TIME_MS =
"expireReadChannelCache";
Review comment:
you need to change the setting key "readChannelCacheExpireTimeMs"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
