sijie commented on a change in pull request #873: Issue280: Add StateManager to
manage Bookie's state, and use it to turn bookie into readonly when
sortedLedgerStorage failed to flush data
URL: https://github.com/apache/bookkeeper/pull/873#discussion_r158922888
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
##########
@@ -132,24 +127,12 @@
// Registration Manager for managing registration
RegistrationManager registrationManager;
- // Running flag
- private volatile boolean running = false;
- // Flag identify whether it is in shutting down progress
- private volatile boolean shuttingdown = false;
- // Bookie status
- private final BookieStatus bookieStatus = new BookieStatus();
private int exitCode = ExitCode.OK;
private final ConcurrentLongHashMap<byte[]> masterKeyCache = new
ConcurrentLongHashMap<>();
- protected final String bookieId;
-
- private final AtomicBoolean rmRegistered = new AtomicBoolean(false);
- protected final AtomicBoolean forceReadOnly = new AtomicBoolean(false);
- // executor to manage the state changes for a bookie.
- final ExecutorService stateService = Executors.newSingleThreadExecutor(
- new
ThreadFactoryBuilder().setNameFormat("BookieStateService-%d").build());
+ StateManager stateManager;
Review comment:
okay make it protected if there are classes extended this class will use
this variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
