ivankelly commented on issue #913: Refactor FileInfo locking and refcounting out IndexPersistenceMgr URL: https://github.com/apache/bookkeeper/pull/913#issuecomment-354277548 @yzang @sijie Pushed a change with the compare and set approach mentioned in https://github.com/apache/bookkeeper/pull/913#issuecomment-354166855. With this change, retaining and releasing a fileinfo uses a lock free type mechanism, while inserting and deleting from the cache uses a ReadWriteLock. Another option would be to dig into guava cache itself to increase the refcount when retrieving, but I'm not even sure that's possible, because guava doesn't use locks in the read path (most of the time).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
