jiazhai commented on a change in pull request #923: Issue-922 Fix shade plugin
configuration
URL: https://github.com/apache/bookkeeper/pull/923#discussion_r159036364
##########
File path: bookkeeper-server/pom.xml
##########
@@ -202,19 +202,16 @@
</configuration>
<executions>
<execution>
+ <id>create-shaded-jar</id>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
<configuration>
<createDependencyReducedPom>true</createDependencyReducedPom>
-
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
Review comment:
I see, It is createDependencyReducedPom that is required.
Seems other guy have met the same
[problem](http://maven.40175.n5.nabble.com/shade-plugin-doesn-t-create-dependency-reduced-pom-td4331135.html).
In my test, after turn `shadedArtifactAttached` into false, it will create a
`./bookkeeper-server/dependency-reduced-pom.xml`, but this change will meet
another error
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (default) on project
bookkeeper-server: Error creating shaded jar: Could not resolve following
dependencies: [javax.jms:jms:jar:1.1 (compile), com.sun.jdmk:jmxtools:jar:1.2.1
(compile), com.sun.jmx:jmxri:jar:1.2.1 (compile)]: Could not resolve
dependencies for project
org.apache.bookkeeper:bookkeeper-server:jar:4.7.0-SNAPSHOT: The following
artifacts could not be resolved: javax.jms:jms:jar:1.1,
com.sun.jdmk:jmxtools:jar:1.2.1, com.sun.jmx:jmxri:jar:1.2.1: Could not
transfer artifact javax.jms:jms:jar:1.1 from/to java.net
(https://maven-repository.dev.java.net/nonav/repository): Cannot access
https://maven-repository.dev.java.net/nonav/repository with type legacy using
the available connector factories: BasicRepositoryConnectorFactory: Cannot
access https://maven-repository.dev.java.net/nonav/repository with type legacy
using the available layout factories: Maven2RepositoryLayoutFactory:
Unsupported repository layout legacy -> [Help 1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
