jiazhai closed pull request #923: Issue-922 Fix shade plugin configuration
URL: https://github.com/apache/bookkeeper/pull/923
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bookkeeper-server/pom.xml b/bookkeeper-server/pom.xml
index be1d40730..a4e265e63 100644
--- a/bookkeeper-server/pom.xml
+++ b/bookkeeper-server/pom.xml
@@ -202,19 +202,16 @@
</configuration>
<executions>
<execution>
+ <id>create-shaded-jar</id>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
<configuration>
<createDependencyReducedPom>true</createDependencyReducedPom>
-
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
- <shadedArtifactAttached>true</shadedArtifactAttached>
- <shadedClassifierName>shaded</shadedClassifierName>
- <minimizeJar>true</minimizeJar>
- <shadeTestJar>true</shadeTestJar>
<artifactSet>
<includes>
+ <include>org.apache.bookkeeper:bookkeeper-common</include>
<include>org.apache.bookkeeper:bookkeeper-proto</include>
<include>com.google.protobuf:protobuf-java</include>
<include>com.google.guava:guava</include>
diff --git a/pom.xml b/pom.xml
index b4d2976c0..6d8662a1f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -124,7 +124,7 @@
<maven-deploy-plugin.version>2.7</maven-deploy-plugin.version>
<maven-jar-plugin.version>2.2</maven-jar-plugin.version>
<maven-javadoc-plugin.version>2.10.4</maven-javadoc-plugin.version>
- <maven-shade-plugin.version>2.4.3</maven-shade-plugin.version>
+ <maven-shade-plugin.version>3.1.0</maven-shade-plugin.version>
<maven-source-plugin.version>2.2.1</maven-source-plugin.version>
<maven-surefire-plugin.version>2.19.1</maven-surefire-plugin.version>
<maven-assembly-plugin.version>2.2.1</maven-assembly-plugin.version>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
