athanatos opened a new pull request #932: ISSUE #931,#907: Add option to track task execution time URL: https://github.com/apache/bookkeeper/pull/932 Fixes a bug in OrderedScheduler introduced in e33ec10aa400f32c2e0278c15ea80a0f624e5919 which failed to track execution time with some callsand adds an option to enable it in the bookie. Also fix bug with task_queued duration. Add a simple mock for remembering stats long enough to verify that counters are actually used and sensible in unit tests and bake it into BookKeeperClusterTestCase so that we can write tests to ensure that the stats are actually counted and make sense. Use said mock to add simple tests for top level read and write stats validating this fix. (@bug W-4276826@) (@bug W-4268290@) Signed-off-by: Samuel Just <[email protected]> > --- > Be sure to do all of the following to help us incorporate your contribution > quickly and easily: > > If this PR is a BookKeeper Proposal (BP): > > - [ ] Make sure the PR title is formatted like: > `<BP-#>: Description of bookkeeper proposal` > `e.g. BP-1: 64 bits ledger is support` > - [ ] Attach the master issue link in the description of this PR. > - [ ] Attach the google doc link if the BP is written in Google Doc. > > Otherwise: > > - [ ] Make sure the PR title is formatted like: > `<Issue # or BOOKKEEPER-#>: Description of pull request` > `e.g. Issue 123: Description ...` > `e.g. BOOKKEEPER-1234: Description ...` > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`. > - [ ] Replace `<Issue # or BOOKKEEPER-#>` in the title with the actual Issue/JIRA number. > > ---
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
