dlg99 commented on a change in pull request #851: Issue 578 : make
MajorCompaction controlled by time of the day/day of the week
URL: https://github.com/apache/bookkeeper/pull/851#discussion_r159347344
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -1101,6 +1105,101 @@ public ServerConfiguration
setMajorCompactionThreshold(double threshold) {
return this;
}
+ /**
+ * Get threshold of median major compaction.
+ *
+ * <p>same with the @see #getMajorCompactionThreshold()
+ * the high threshold is used when the system is on a low load status
Review comment:
The change has nothing to do with adjusting compaction parameters based on
actual system/bookie load as one can think after reading this, it adjusts them
on schedule (which supposed to reflect one's best guess for the system load).
I'd adjust the doc text to reflect this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
