zhaijack commented on a change in pull request #936: Issue 897: un-bind
zookeeper from bookkeeper admin
URL: https://github.com/apache/bookkeeper/pull/936#discussion_r159361802
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
##########
@@ -842,15 +848,18 @@ public int runCmd(CommandLine cmdLine) throws Exception {
return -1;
}
- ZooKeeper zk = null;
LedgerManagerFactory mFactory = null;
LedgerManager m = null;
try {
- zk = ZooKeeperClient.newBuilder()
- .connectString(bkConf.getZkServers())
- .sessionTimeoutMs(bkConf.getZkTimeout())
- .build();
- mFactory =
LedgerManagerFactory.newLedgerManagerFactory(bkConf, zk);
+ mFactory = LedgerManagerFactory.newLedgerManagerFactory(
+ bkConf,
+ new ZkLayoutManager(
Review comment:
Thanks, will change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
