eolivelli commented on a change in pull request #936: Issue 897: un-bind
zookeeper from bookkeeper admin
URL: https://github.com/apache/bookkeeper/pull/936#discussion_r159385048
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationClient.java
##########
@@ -353,5 +368,29 @@ public synchronized void
unwatchReadOnlyBookies(RegistrationListener listener) {
}
return newBookieAddrs;
}
+ @VisibleForTesting
+ public void setLayoutManager(LayoutManager layoutManager) {
Review comment:
Using powermock we can stop opening the internals to users with public
methods
@sijie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
