yzang commented on a change in pull request #913: Refactor FileInfo locking and
refcounting out IndexPersistenceMgr
URL: https://github.com/apache/bookkeeper/pull/913#discussion_r159582189
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexPersistenceMgr.java
##########
@@ -80,15 +77,13 @@ public static final String getLedgerName(long ledgerId) {
}
// use two separate cache for write and read
- final Cache<Long, FileInfo> writeFileInfoCache;
- final Cache<Long, FileInfo> readFileInfoCache;
+ final Cache<Long, CachedFileInfo> writeFileInfoCache;
+ final Cache<Long, CachedFileInfo> readFileInfoCache;
+ final FileInfoBackingCache fileInfoBackingCache;
Review comment:
@ivankelly The previous issue with concurrent hashmap in Twitter is because
the refCount is not correctly incremented when we get the FileInfo from the
map. I think that issue is already addressed in your change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
