merlimat commented on a change in pull request #917: Issue 915: Part 2 - Add
crc32c integer/long checksum utils under `com.scurrilous.circe.checksum`
URL: https://github.com/apache/bookkeeper/pull/917#discussion_r159609088
##########
File path: circe-checksum/pom.xml
##########
@@ -48,6 +48,12 @@
<version>${guava.version}</version>
</dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-buffer</artifactId>
Review comment:
For this artifact we need to be careful. Sure, the checksum only uses the
`ByteBuf`, though in the other components we're already using the `netty-all`
dependency which already includes the `netty-buffer` but maven will pull in
both since it doesn't know it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
