ivankelly commented on issue #930: [WIP] Issue #903: Bc tests based on docker
URL: https://github.com/apache/bookkeeper/pull/930#issuecomment-355237736
 
 
   I don't have a strong opinion on whether we use docker for these tests or 
not, but for sure we will use docker for integration tests soon, so we may as 
well take the plunge now. Also, the isolation is very nice to have.
   
   @sijie regarding the official image, we can't use that because that only 
ships with one version of bookkeeper. We need all versions, so that we can 
verify upgrades between versions. Separate docker images for each version 
doesn't work, even if sharing volumes, because the IP addresses will change.
   
   @eolivelli You mentioned before that your corp policy doesn't allow docker. 
Is this just locally? Can you run on a server? I wouldn't expect all users to 
run these tests every time before they push. They will be heavy (with should be 
and will be testing far more BC stuff than we do now), so you probably don't 
even want to run them on a laptop.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to