eolivelli commented on issue #930: [WIP] Issue #903: Bc tests based on docker URL: https://github.com/apache/bookkeeper/pull/930#issuecomment-355258844 +1 for docker and the current approach. I image you will clean up this patch. I wonder if checkstyle can work on groovy files. I am using a lot docker + Jenkins to run tests and integration tests in my company. We have strict rules because technically docker does not provide a strong sandbox. For it won't be a real problem maybe it would for new contributors. I propose to move forward and if contributors will have problems we will see how to help. It is important for a contributor which needs to write a BC test to be able to work efficiently. I think that accesssing the logs for such ephemeral containers could be nasty, for instance
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
