jvrao commented on a change in pull request #944: Introduce MockClock and
MockExecutorController to improve timer-based testing
URL: https://github.com/apache/bookkeeper/pull/944#discussion_r159733285
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java
##########
@@ -40,117 +45,109 @@
/**
* Thread to monitor the disk space periodically.
*/
-class LedgerDirsMonitor extends BookieThread {
+class LedgerDirsMonitor {
Review comment:
I understand you are trying to use an executor for this, which is nice, but
does it have to do anything with introducing mock executor? If not, this being
a different commit will help reviewer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
