sijie commented on a change in pull request #946: ISSUE #945: Enabling
BookieShell for LocalBookKeeper
URL: https://github.com/apache/bookkeeper/pull/946#discussion_r159825388
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -770,6 +771,26 @@ public ServerConfiguration
setAllowStorageExpansion(boolean val) {
return this;
}
+ /**
Review comment:
I am not sure we should put this settings in a bookie config. A server
configuration is specific to a bookie instance.
A better solution is: LocalBookKeeper takes parameter from command line
args. e.g. LocalBookKeeper <numBookies> <localbookie config>. so this setting
is only for LocalBookKeeper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
