reddycharan commented on a change in pull request #948: ISSUE #947: ZK configs
for LocalBookkeeper
URL: https://github.com/apache/bookkeeper/pull/948#discussion_r159945232
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
##########
@@ -280,11 +291,19 @@ static void
startLocalBookiesInternal(ServerConfiguration conf,
List<File> bkTmpDirs = null;
try {
if (shouldStartZK) {
- zkTmpDir = IOUtils.createTempDir("zookeeper", dirSuffix);
+ if (null == zkDataDir) {
+ zkTmpDir = IOUtils.createTempDir("zookeeper", dirSuffix);
Review comment:
IOUtils.createTempDir creates dir in temp folder and
Files.createTempDirectory creates dir in the specified directory, which we are
intending to do with this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
