ivankelly commented on issue #851: Issue 578 : make MajorCompaction controlled by time of the day/day of the week URL: https://github.com/apache/bookkeeper/pull/851#issuecomment-355747002 > However IMO using an external cron job triggering things increases ops complexity: 1) you have multiple locations to manage things (bookie config, cron configs) 2) you need to debug multiple locations when issues occur (external cron, http service, and the bookie). I disagree. Every ops person knows how to use cron, they should be able to tap out a cron schedule from memory. Even if we're cron compatible, the user would have to dig into our docs too see what the format is, and find out where is incompatible with crontab(5). Debugging cron itself is easy. You can even make it send email on failures. But it wouldn't even need to be cron, it would be up to the ops to decide what to use to trigger the GC. The underlying goal of this change is to allow the user more control over when GC runs. A HTTP endpoint, leave the entire decision to the user. - They can decide based on time or some other criteria. - They can schedule without rebooting the bookies - They can control the schedule centrally, so all bookies don't end up running GC at the same time - They can kick off adhoc GC when they see they need to. And I guess this would take 100-150 LOC, 10% of the current patch. What's more, it wouldn't change anything in the core GC mechanism, it just calls triggerGC that we already test in a bunch of places.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
