sijie commented on issue #851: Issue 578 : make MajorCompaction controlled by 
time of the day/day of the week
URL: https://github.com/apache/bookkeeper/pull/851#issuecomment-355761671
 
 
   @ivankelly it is understandable that different people have different 
opinions regarding ops. We already have http, it doesn't affect people who want 
to use http. If people doesn't want to use an external cron, they can configure 
intervals or a cron expression to when they want to schedule compaction.
   
   > And I guess this would take 100-150 LOC, 10% of the current patch. What's 
more, it wouldn't change anything in the core GC mechanism, it just calls 
triggerGC that we already test in a bunch of places
   
   If you follow the comments, what we are discussing at the end of this PR is, 
not change any GC mechanisms, only provided a mechanism of when to trigger the 
GC tasks. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to