ivankelly commented on a change in pull request #888: Rework of binary distribution licenses URL: https://github.com/apache/bookkeeper/pull/888#discussion_r161189447
########## File path: bookkeeper-dist/src/main/resources/NOTICE-all.bin.txt ########## @@ -1,55 +1,136 @@ Apache BookKeeper -Copyright 2011-2017 The Apache Software Foundation +Copyright 2011-2018 The Apache Software Foundation -Licensed under the Apache License, Version 2.0 (the -"License"); you may not use this file except in compliance +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +------------------------------------------------------------------------------------ +- lib/io.dropwizard.metrics-metrics-core-3.1.0.jar Review comment: the versions are there to facilitate automated checking. if we remove the versions we can't ensure that what is in the notice file exists in the shipped tarball. It will need to be checked manually, so more chance of a -1 on a release candidate. Also, notices can change between version, so the rationale for having them in the LICENSE holds for the NOTICE also. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
