ivankelly commented on a change in pull request #1022: Only run integration
tests with -DintegrationTests
URL: https://github.com/apache/bookkeeper/pull/1022#discussion_r162753297
##########
File path: tests/integration-tests-base/pom.xml
##########
@@ -63,6 +63,8 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
+ <!-- only run tests when -DintegrationTests is specified //-->
+ <skipTests>true</skipTests>
Review comment:
there is a profile "integrationTests", so it can be activated by -P, I
created the activate by system property so that docker would also be activated.
I _want_ it to be explicit for the user to run these tests. I don't want
users to have to have docker installed to be able to get through a "mvn
install".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
