sijie commented on a change in pull request #925: Issue611: restrict max
ensemble change numbers
URL: https://github.com/apache/bookkeeper/pull/925#discussion_r162833864
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
##########
@@ -1618,6 +1619,26 @@ public ClientConfiguration
setDisableEnsembleChangeFeatureName(String disableEns
return this;
}
+ /**
+ * Get the MaxNum for ensemble change.
+ *
+ * @return value of MaxNumEnsembleChanges, default 100.
+ */
+ public int getMaxNumEnsembleChanges() {
+ return getInt(MAX_NUM_ENSEMBLE_CHANGES, 100);
Review comment:
make default as Integer.MAX_VALUE, so by default this feature is *OFF*. if
users want to use this feature, he can turn on by setting it to a lower value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
