eolivelli commented on a change in pull request #965: Issue 933: Add support
for PEM Key file formats
URL: https://github.com/apache/bookkeeper/pull/965#discussion_r163404260
##########
File path: bookkeeper-server/pom.xml
##########
@@ -284,16 +284,37 @@
<exclude>**/.project</exclude>
<exclude>**/.checkstyle</exclude>
<exclude>**/.settings/*</exclude>
- <exclude>certs/keyStoreClientPassword.txt</exclude>
- <exclude>certs/keyStoreServerPassword.txt</exclude>
- <exclude>certs/trustStorePassword.txt</exclude>
- <exclude>src/test/resources/cacerts</exclude>
+ <exclude>src/test/resources/server-key.pem</exclude>
+ <exclude>src/test/resources/server-key.p12</exclude>
+ <exclude>src/test/resources/server-key.jks</exclude>
+ <exclude>src/test/resources/server-cert.pem</exclude>
+ <exclude>src/test/resources/client-key.pem</exclude>
+ <exclude>src/test/resources/client-key.p12</exclude>
+ <exclude>src/test/resources/client-key.jks</exclude>
+ <exclude>src/test/resources/client-cert.pem</exclude>
<exclude>src/test/resources/keyStoreClientPassword.txt</exclude>
<exclude>src/test/resources/keyStoreServerPassword.txt</exclude>
- <exclude>src/test/resources/trustStorePassword.txt</exclude>
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>1.6.0</version>
+ <executions>
+ <execution>
+ <id>Generate Self-Signed Certificates</id>
+ <phase>generate-test-resources</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+
<workingDirectory>${basedir}/src/test/resources</workingDirectory>
+
<executable>${basedir}/src/test/resources/generateKeysAndCerts.sh</executable>
Review comment:
It would be fine for me, thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
