ArvinDevel commented on a change in pull request #925: Issue611: restrict max
ensemble change numbers
URL: https://github.com/apache/bookkeeper/pull/925#discussion_r163469391
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeperTestCase.java
##########
@@ -219,7 +272,10 @@ private void submit(Runnable operation) {
}
protected void registerMockEntryForRead(long ledgerId, long entryId,
BookieSocketAddress bookieSocketAddress,
- byte[] entryData, long lastAddConfirmed) {
+ byte[] entryData, long lastAddConfirmed) throws BKException{
+ if (failedBookies.contains(bookieSocketAddress)) {
+ throw BKException.create(NoBookieAvailableException);
Review comment:
I think the exception in write path is necessary, it's used to trigger
ensemble change, otherwise the ensemble will never be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
