eolivelli commented on a change in pull request #889: BP-14 Implementation of
WriteFlag.DEFERRED_SYNC on Journal
URL: https://github.com/apache/bookkeeper/pull/889#discussion_r164273138
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
##########
@@ -959,19 +979,31 @@ public void run() {
}
journalFlushWatcher.reset().start();
bc.flush(false);
+
+ for (int i = 0; i < toFlush.size(); i++) {
Review comment:
@sijie I have reverted the change and move the logic to a different branch.
Tests are passing.
Is this what you are thinking ?
I wonder if this approach really reduces the number of fsyncs as anyway we
are issueing a "ForceWriteRequest".
I would like that in the case all the entries written to the bookie are
DEREFFED_SYNC the behaviour should be like having syncData = false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
