jiazhai opened a new issue #1079: FinagleStatsProvider stats provider doesn't cache stats logger objects URL: https://github.com/apache/bookkeeper/issues/1079 same as issue #1078, [FinagleStatsProvider](https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-finagle-provider/src/main/java/org/apache/bookkeeper/stats/twitter/finagle/FinagleStatsProvider.java) also need the cache. ``` It turns out that unlike other stats provider implementation, the prometheus stats provider doesn't have any caching mechanism built in. for each scope, getOpStatsLogger and getCounter call, it will return a brand new object. This would cause it generate several stats object for each add/read entry calls. This brings in a burden to the bookie jvm, and would cause other issue on bookie, for example, might cause the direct buffer building up and cause jvm oom. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
