sijie commented on a change in pull request #889: BP-14 Implementation of
WriteFlag.DEFERRED_SYNC on Journal
URL: https://github.com/apache/bookkeeper/pull/889#discussion_r165160071
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
##########
@@ -959,19 +979,31 @@ public void run() {
}
journalFlushWatcher.reset().start();
bc.flush(false);
+
+ for (int i = 0; i < toFlush.size(); i++) {
Review comment:
@eolivelli
This is different from using 'syncData = false'. because the goal here is
add entries can complete before fsync, while the whole assumption of lac still
remain. the `syncData = fase` is disabling fsync completely. These two cases
have different durability guarantees.
Also I don't think the goal is to reduce the number of fsyncs. But if you
want to reduce the number of fsyncs, you can anyway increase the flush commit
interval or flush buffer size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
