sijie commented on a change in pull request #1091: BOOKKEEPER-1063:Write keeps
refCnt longer
URL: https://github.com/apache/bookkeeper/pull/1091#discussion_r165187689
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
##########
@@ -232,6 +231,7 @@ public void safeRun() {
sendWriteRequest(writeSet.get(i));
}
} finally {
+ hasRun = true;
Review comment:
there is a return at line 216?
if the purpose is to setting this after it actually finished running, you
should have pull all the logic in a try-finally block, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
