sijie commented on issue #1092: Dont log ledgermetadata which contains password. URL: https://github.com/apache/bookkeeper/pull/1092#issuecomment-362074977 well I think there are two questions here: - if we remove ledger metadata here, this logging statement is most likely useless. is that expected behavior we want? If the concern is about `password`, can't we just not dump password instead of removing the entire ledger metadata here. - "password": is safesforce really using this for authentication? we already have tls and correct authentication framework to do authentication. "password" should be considered dead and removed at some point though. I am asking this is mostly to learn your use case. AFAIK, the password is not really used at either yahoo or twitter.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
