eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag 
DEFERRED_SYNC Client Side Implementation
URL: https://github.com/apache/bookkeeper/pull/853#discussion_r165689136
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
 ##########
 @@ -524,10 +526,15 @@ void writeLac(final long ledgerId, final byte[] 
masterKey, final long lac, ByteB
      *          Add options
      */
     void addEntry(final long ledgerId, byte[] masterKey, final long entryId, 
ByteBuf toSend, WriteCallback cb,
-                  Object ctx, final int options) {
+                  Object ctx, final int options, final EnumSet<WriteFlag> 
writeFlags) {
         Object request = null;
         CompletionKey completionKey = null;
         if (useV2WireProtocol) {
+            if (writeFlags.contains(WriteFlag.DEFERRED_SYNC)) {
+                LOG.error("invalid writeflags {} for v2 protocol", writeFlags);
+                toSend.release();
+                cb.writeComplete(BKException.Code.IllegalOpException, 
ledgerId, entryId, addr, ctx);
 
 Review comment:
   done, see BookKeeperTest#testCannotUseWriteFlagsOnV2Protocol

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to