reddycharan commented on a change in pull request #1099: Fix auditor shutdown 
logic and move decommision tests out of BookKeeperAdminTest
URL: https://github.com/apache/bookkeeper/pull/1099#discussion_r165711029
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
 ##########
 @@ -707,8 +707,7 @@ public void processResult(int rc, String s, Object obj) {
      */
     public void shutdown() {
         LOG.info("Shutting down auditor");
-        submitShutdownTask();
-
+        executor.shutdown();
 
 Review comment:
   yeah I get that, but I'm wondering why it wasn't like this before? why did 
the original author - 
https://github.com/apache/bookkeeper/commit/e5b0dd0d9e47394202f5a20cedf409f487d90beb
 went through this extra round of hassle for shutdown deliberately. Is it ok 
now to not to have this extra scrutiny with the shutdown process?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to